Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Middlewares.resolve public #2762

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Make Middlewares.resolve public #2762

merged 1 commit into from
Jan 26, 2022

Conversation

samisuteria
Copy link
Contributor

Makes the resolve function public so users of Vapor can use it when making their own Responder.

@samisuteria
Copy link
Contributor Author

My use case: I'm making a custom Responder that behaves differently than Vapor.DefaultResponder and I want to be able to chain middleware to the route's responder. But in order to get access to that I need to make the resolve function public.

0xTim
0xTim approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with opening this up for other responders

@0xTim 0xTim added the no-release-needed Doesn't require a release label Jan 26, 2022
@0xTim
Copy link
Member

0xTim commented Jan 26, 2022

Will roll this into a release with #2761

@0xTim 0xTim merged commit 2867052 into vapor:main Jan 26, 2022
@0xTim 0xTim mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
no-release-needed Doesn't require a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samisuteria @0xTim