Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling unicode characters in multipart filenames #2826

Merged
merged 5 commits into from May 17, 2022
Merged

Fix handling unicode characters in multipart filenames #2826

merged 5 commits into from May 17, 2022

Conversation

BennyDeBock
Copy link
Member

@BennyDeBock BennyDeBock commented May 16, 2022 •
edited by 0xTim

Correctly handle the filename* ContentDisposition header to be compliant with RFC-5987 as described in RFC 6266. This allows handling of unicode and other format characters in filenames.

Resolves #2802

@BennyDeBock BennyDeBock requested a review from 0xTim May 16, 2022 11:26
@BennyDeBock BennyDeBock marked this pull request as ready for review May 16, 2022 11:27
@BennyDeBock BennyDeBock mentioned this pull request May 16, 2022
Closed
@BennyDeBock BennyDeBock changed the title Bug/multipart chinese error Fix error on multipart file upload throwing an error with unicode characters in the filename May 16, 2022
@0xTim 0xTim added the semver-patch Internal changes only label May 16, 2022
@0xTim 0xTim changed the title Fix error on multipart file upload throwing an error with unicode characters in the filename Fix handling unicode characters in multipart filenames May 16, 2022
0xTim
0xTim requested changes May 16, 2022
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a test to make sure we don't break it again in the future if possible

0xTim
0xTim approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@BennyDeBock BennyDeBock merged commit 21dde33 into main May 17, 2022
@BennyDeBock BennyDeBock deleted the bug/multipartChineseError branch May 17, 2022 08:42
@VaporBot
Copy link
Contributor

These changes are now available in 4.59.1

@0xTim 0xTim mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw error when upload a file which has a Chinese name by Multipart/form-data
3 participants
@BennyDeBock @VaporBot @0xTim