Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds action to update README on new backer #2900

Merged
merged 3 commits into from Oct 27, 2022
Merged

Adds action to update README on new backer #2900

merged 3 commits into from Oct 27, 2022

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Oct 17, 2022

Adds a GitHub Action to automatically update the README.md when someone sponsors the organisation

@ptoffy ptoffy requested a review from 0xTim October 17, 2022 13:02
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So a few questions - does this actually commit the changes (I'm assuming we're going to have to do that manually) and is there a way to sort the backers? Just had a quick look and I don't think so which is fine

Comment on lines 25 to 29
- name: Deploy to GitHub Pages 🚀
uses: JamesIves/github-pages-deploy-action@v4
with:
branch: main
folder: "."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this as we're not deploying to Pages right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated that part of the action to just commit the new changes without deploying them to pages.
Backers aren't sorted

@ptoffy ptoffy requested a review from 0xTim October 17, 2022 15:45
@0xTim 0xTim merged commit a4d8bb2 into main Oct 27, 2022
@0xTim 0xTim deleted the sponsors-readme branch October 27, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants