Fix up Imports #2963
Merged
Fix up Imports #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
approved these changes
Feb 19, 2023
| with: | ||
| fetch-depth: 0 | ||
| - name: Build | ||
| run: swift build -Xswiftc -DBUILDING_DOCC |
There was a problem hiding this comment.
-D flags can't be passed directly to swift build? I could've sworn that was supported.
There was a problem hiding this comment.
Honestly I didn't actually try! I'll try in the next repo and we can always backport it
| @@ -37,3 +37,13 @@ jobs: | |||
| with_coverage: false | |||
| with_tsan: false | |||
There was a problem hiding this comment.
While we're at it, we should either turn off TSan for the provider tests or turn it on for the unit tests.
There was a problem hiding this comment.
It should probably be on really. I'll make a note to enable it when I do some Sendable work
|
@gwynne We should probably raise issues for all these API checker problems... 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up the imports in Vapor so it will build without exporting everything.
This allows us to avoid exports when building documentation and future proofs us.
Also run this through CI to avoid PRs breaking the docs