-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested Routes #40
Nested Routes #40
Conversation
This looks good. I will try it out and merge when I'm back on my computer. |
Just discussing with @loganwright on Slack... Currently all parameters are named for nested resources i.e. |
@@ -247,11 +247,33 @@ Here the `HeartbeatControllers`'s index method will be called when `http://examp | |||
|
|||
Resource controllers take advantage of CRUD-like `index`, `show`, `store`, `update`, `destroy` methods to make setting up REST APIs easy. | |||
|
|||
*Single Resources* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use ###
Looks great. Just a few comments. |
Done. |
Great, thank you! |
Ok, this is now working on Ubuntu (via docker) and I have added tests for simple (single) and nests resources.
I also simplified the path construction by removing the Zip2Sequence which was unnecessarily verbose: