Full cookie serialization #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ketzusaka Do you know which browsers don't work with the single set-cookie header? |
|
@tannernelson I tested specifically on Chrome. I don't believe it was working in safari either as things weren't operating as I expected there, but I'd have to double check on that. Also, the format for the Expires attribute appears to require a format that would break multiple cookies in a single Set-Cookie header, and that is why it is recommended to use multiple header rows. |
|
@ketzusaka @tannernelson I added a mini commit on here that will give us multi cookie support until we implement something more comprehensive. This was tested on Chrome and Safari 👍 |
|
oh nice, surprised that works haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the responsibility of serializing cookie data to the
Cookiestruct. This is a better separation of concerns in my eyes. TheCookiesserialization is updated to use the new method onCookie, which fixes an issue where the attributes of a cookie were never set.There is still the issue where we're folding all of the cookie properties into a single Set-Cookie header, which doesn't seem to work in some browsers; that fix will come in a subsequent PR.