Dependency cleanup #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eanup # Conflicts: # Package.swift # Vapor.xcodeproj/project.pbxproj
…ependency-cleanup
# Conflicts: # Sources/Branch.swift # Sources/BranchRouter.swift # Tests/RouteTests.swift
|
|
||
| var paths: [String] = [] | ||
|
|
||
| for (index, component) in path.componentsSeparatedByString(".").enumerate() { |
There was a problem hiding this comment.
This should be components. Any reason for swapping the original logic in this section?
There was a problem hiding this comment.
When I was trying to get the RouteTests.swift to work, there was an error I was trying to debug. It involved changing this.
I'm going to put it back to the original.
| .joinWithSeparator("") | ||
|
|
||
| let fullPath = shortPath + last | ||
| print(fullPath) |
There was a problem hiding this comment.
I don't think this print is meant to be there.
|
|
||
| let shortPath = path.componentsSeparatedByString(".") | ||
| .flatMap { component in | ||
| return ["\(component)s", "/:\(component)_id/"] |
There was a problem hiding this comment.
This pluralisation will be right some of the time but will be incorrect a lot as so many nouns in English are irregular, e.g. leaf -> leaves, child -> children, appendix -> appendices etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the JSON serializer and SHA256 Cryptography into Vapor without dependencies.
It also cleans up some
Routelogic.