Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fails when run from PR #102

Closed
0xTim opened this issue Sep 5, 2021 · 1 comment
Closed

CI fails when run from PR #102

0xTim opened this issue Sep 5, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Good first issues #1 Beginner Issues

Comments

@0xTim
Copy link
Member

0xTim commented Sep 5, 2021

The way we test Vapor as on onward package doesn't work when the PR is from a fork because it tries to check out a revision that doesn't exist. The main Vapor package checks out both the package and forward provider and uses them both so we should copy that
@0xTim 0xTim added bug Something isn't working good first issue Good for newcomers bug Something isn't working and removed bug Something isn't working labels Sep 5, 2021
@BennyDeBock BennyDeBock added this to To do in Beginner Issues Mar 4, 2022
@gwynne
Copy link
Member

gwynne commented May 26, 2023

Long since fixed.

@gwynne gwynne closed this as completed May 26, 2023
@VaporBot VaporBot moved this from To do to Done in Beginner Issues May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Beginner Issues
  
Done
Good first issues #1
  
To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gwynne @0xTim