-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sendable Crash even on 2.13.0 / Swift 5.7 #139
Comments
@PatrickPijnappel what does your web socket code look like? We're probably missing a hop somewhere |
@0xTim Basically this:
|
What is self in this instance and queue? Im assuming the web socket is being created outside of the queue closure? |
|
@PatrickPijnappel ah ok, I misread this initially. Setting the WS callbacks must be done on the Websocket's One workaround might be to wrap your calls in websocket.eventLoop.execute {
websocket.onBinary {
// ...
}
} That should enforce that the mutations are done on the correct event loop, but mixing concurrency, event loops and dispatch queues like this is always going to cause issues |
@0xTim Ah i see, thank you! |
Describe the bug
We're getting this crash with 2.12.0, then it was fixed with 2.12.1 but failing again with 2.13.0 (Swift 5.7)
To Reproduce
(Not sure at this point)
Expected behavior
No crash.
Environment
The text was updated successfully, but these errors were encountered: