Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client should send ping #66

Closed
bridger opened this issue Mar 1, 2020 · 2 comments
Closed

Client should send ping #66

bridger opened this issue Mar 1, 2020 · 2 comments
Labels
enhancement New feature or request
Projects

Comments

@bridger
Copy link
Contributor

bridger commented Mar 1, 2020

Amazon's Application Load Balancers are configured to shut down connections that haven't had traffic.

Sending a ping on the connection every so often is enough to keep the connection alive. I plan to implement this functionality on the WebSocket class and will submit a PR.

@tanner0101 tanner0101 added the enhancement New feature or request label Mar 5, 2020
@tanner0101 tanner0101 added this to To Do in Vapor 4 via automation Mar 5, 2020
@tanner0101
Copy link
Member

@bridger thanks. We automatically return a pong already for the server case but it looks like the client case needs to be sending ping at some interval. eventLoop.scheduledTask will probably work well for this.

@bridger
Copy link
Contributor Author

bridger commented Mar 5, 2020

@tanner0101 The scheduleTask API is what I used to address this issue in #68

Sent with GitHawk

@tanner0101 tanner0101 moved this from Backlog to Awaiting Updates in Vapor 4 Mar 6, 2020
@tanner0101 tanner0101 changed the title Amazon's Application Load Balancer is closing connections for innactivity Client should send ping Mar 30, 2020
@0xTim 0xTim closed this as completed May 25, 2023
Vapor 4 automation moved this from Awaiting Updates to Done May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Vapor 4
  
Done
Development

No branches or pull requests

3 participants