Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project deprecated? #35

Closed
jgh- opened this issue Apr 7, 2019 · 3 comments
Closed

Is this project deprecated? #35

jgh- opened this issue Apr 7, 2019 · 3 comments

Comments

@jgh-
Copy link

jgh- commented Apr 7, 2019

This project and vapor core don't really seem to be compatible with swift 5/NIO 2.0, whereas your http project (now http-kit) is... Are you planning on updating this one? If not, could you please put something in the readme to indicate that it is deprecated.

@MihaelIsaev
Copy link
Member

It works well with Vapor 3 + Swift 5 + NIO1. Vapor 3 is the current major version of the framework cause as far as I know Vapor 4 isn't released yet https://github.com/orgs/vapor/projects/2 so it means that there is no need to mark this package as deprecated until Vapor 4 is released.

whereas your http project (now http-kit) is...

it's a package for Vapor 4 which is still in active development state

@jgh-
Copy link
Author

jgh- commented Apr 7, 2019

You didn't really answer my question, is there a plan to update vapor websockets to NIO 2? I don't see any mention of it in that project board you linked to. You don't have to wait for a new version to be released to tell people a thing is deprecated. I want to know if I should bother waiting for you guys to update this thing or if I should remove it from my project....

@tanner0101
Copy link
Member

@jgh- it hasn't been decided yet, so I wouldn't wait for us to update it. We're currently focused on working together with the Swift Server group to create a shared HTTP client package. Whether or not that will pan out remains to be seen, but I can't make any promises about this package until we know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants