R48 fails to build on non-x86 architectures e.g., aarch64

[jbeich]

From error log:

In file included from src/core/kernel/x86/merge_avx2.c:21:
In file included from /usr/lib/clang/8.0.0/include/immintrin.h:28:
/usr/lib/clang/8.0.0/include/mmintrin.h:64:12: error: invalid conversion between vector type '__m64' (vector of 1 'long long' value) and integer type 'int' of different size
    return (__m64)__builtin_ia32_vec_init_v2si(__i, 0);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[...]

vapoursynth/Makefile.am

Line 94 in 7c488b5

libvapoursynth_la_LIBADD = $(ZIMG_LIBS) $(DLOPENLIB) libexprfilter.la libvapoursynth_avx2.la

[marillat]

I confirm this issue under armel, armhf and arm64 Debian unstable

armhf and armel architectures

../src/core/kernel/x86/generic_avx2.cpp:23:10: fatal error: immintrin.h: No such file or directory
   23 | #include <immintrin.h>

arm64

../src/core/cpufeatures.cpp: In function ‘void doGetCPUFeatures(CPUFeatures*)’:
../src/core/cpufeatures.cpp:116:39: error: ‘HWCAP_ARM_HALF’ was not declared in this scope
  116 |     cpuFeatures->half_fp = !!(hwcap & HWCAP_ARM_HALF);
      |                                       ^~~~~~~~~~~~~~
../src/core/cpufeatures.cpp:117:36: error: ‘HWCAP_ARM_EDSP’ was not declared in this scope
  117 |     cpuFeatures->edsp = !!(hwcap & HWCAP_ARM_EDSP);
      |                                    ^~~~~~~~~~~~~~
../src/core/cpufeatures.cpp:118:38: error: ‘HWCAP_ARM_IWMMXT’ was not declared in this scope
  118 |     cpuFeatures->iwmmxt = !!(hwcap & HWCAP_ARM_IWMMXT);
      |                                      ^~~~~~~~~~~~~~~~
../src/core/cpufeatures.cpp:119:36: error: ‘HWCAP_ARM_NEON’ was not declared in this scope
  119 |     cpuFeatures->neon = !!(hwcap & HWCAP_ARM_NEON);
      |                                    ^~~~~~~~~~~~~~
../src/core/cpufeatures.cpp:120:41: error: ‘HWCAP_ARM_FAST_MULT’ was not declared in this scope
  120 |     cpuFeatures->fast_mult = !!(hwcap & HWCAP_ARM_FAST_MULT);
      |                                         ^~~~~~~~~~~~~~~~~~~
../src/core/cpufeatures.cpp:121:38: error: ‘HWCAP_ARM_IDIVA’ was not declared in this scope
  121 |     cpuFeatures->idiv_a = !!(hwcap & HWCAP_ARM_IDIVA);
      |                                      ^~~~~~~~~~~~~~~
make: *** [Makefile:1717: src/core/libvapoursynth_la-cpufeatures.lo] Error 1

[EleonoreMizo]

Same here. GCC suggests other macros like HWCAP_ASIMDHP, __ARM_NEON or HWCAP_ATOMICS

[dubhater]

The problem with the AVX2 code should be fixed now. I don't know about the other errors.

[marillat]

Fix in a9b657d break the build (arch is amd64)

Makefile.am:257: error: unterminated conditionals: VSCORE_TRUE
Makefile.am: installing './depcomp'
/usr/share/automake-1.16/am/progs.am: warning: automake does not support am__installdirs being defined conditionally
Makefile.am:135:   while processing 'bin_PROGRAMS'
autoreconf: automake failed with exit status: 1

[dubhater]

Fixed now.

[myrsloik]

Fix verified on my rpi4