Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create defaults for a nice circular button #198

Open
bitspittle opened this issue Dec 20, 2022 · 2 comments
Open

Create defaults for a nice circular button #198

bitspittle opened this issue Dec 20, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@bitspittle
Copy link
Collaborator

Probably a CircleButton variant? Alternately, a CircleButton composable, which may be better if we start adding in size parameters to our widgets? (Since otherwise it might be hard to respond to different sizes)

Currently, if you clip with a Circle and set padding to 0.px, you get something where the button edges show slightly:

Test image

Anyway, if we support something official, then users won't have to worry about this.

I'm leaning towards making a CircleButton composable; it is readable and a bit more flexible for future changes.

@bitspittle bitspittle added the enhancement New feature or request label Dec 20, 2022
@bitspittle bitspittle added this to the 1.0 milestone Dec 20, 2022
@bitspittle
Copy link
Collaborator Author

Added to 1.0 because it should be trivial, and I think would be used very commonly.

@bitspittle
Copy link
Collaborator Author

Comment from Discord: Before adding a CircleButton, make sure something like clip(radius = 50.percent) doesn't work with multiple sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Kobweb Frontend
Awaiting triage
Development

No branches or pull requests

1 participant