Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Compose Resources? #486

Open
bitspittle opened this issue Mar 16, 2024 · 5 comments
Open

Support Compose Resources? #486

bitspittle opened this issue Mar 16, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@bitspittle
Copy link
Collaborator

Compose 1.6.0 introduces common resources for Compose Multiplatform.

https://blog.jetbrains.com/kotlin/2024/02/compose-multiplatform-1-6-0-release/

Does this include Compose HTML? If so, what do we need to do to make sure it's supported in Kobweb?

@bitspittle bitspittle added the enhancement New feature or request label Mar 16, 2024
@bitspittle bitspittle self-assigned this Mar 16, 2024
@ellet0
Copy link
Contributor

ellet0 commented Mar 17, 2024

Take a look at this
image

Compose HTML is different from Compose Web

image

@bitspittle
Copy link
Collaborator Author

Here's a discussion from the Kotlin slack:

https://slack-chats.kotlinlang.org/t/16672173/are-compose-multiplatform-resources-part-of-the-1-6-0-releas

Compose Resources are supported but using them adds a heavy dependency to your project, from what it sounds like.

@bitspittle
Copy link
Collaborator Author

Sure, although I suspect a valid use case for Kobweb for some users will be to share common code between their site and mobile applications. It would be nice to get confirmation from users, since at the moment I'm just guessing.

Also, eventually Kobweb should make an official stance on how localization is recommended. So far I've been avoiding it because I just don't know enough yet.

@ellet0
Copy link
Contributor

ellet0 commented May 24, 2024

Compose Multiplatform 1.6.10 is out, the Compose resources are stable now but still no sign if it will be officially supported for Compose for HTML too.

@bitspittle
Copy link
Collaborator Author

bitspittle commented May 24, 2024

Note that with K2 we're going to be migrating away from the Compose Plugin and to the Compose Compiler plugin instead (it is clear the Compose plugin is more and more being treated as a plugin for CMP, which means they keep introducing stuff that don't reallly apply to the Kobweb / Compose HTML experience).

See also:

In light of this new direction, it will be worth revisiting this issue to see if it even still makes sense to do post K2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Kobweb Frontend
Awaiting triage
Development

No branches or pull requests

2 participants