Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using custom S3 endpoint #362

Merged
merged 8 commits into from
Jun 6, 2024
Merged

fix: using custom S3 endpoint #362

merged 8 commits into from
Jun 6, 2024

Conversation

holtgrewe
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 41.86047% with 25 lines in your changes missing coverage. Please review.

Project coverage is 81%. Comparing base (9a661b0) to head (2819e14).
Report is 18 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #362   +/-   ##
===================================
- Coverage    81%    81%   -1%     
===================================
  Files        44     44           
  Lines      6115   6148   +33     
===================================
+ Hits       4967   4984   +17     
- Misses     1148   1164   +16     
Files Coverage Δ
src/common/s3.rs 38% <100%> (+<1%) ⬆️
src/seqvars/query/mod.rs 88% <100%> (ø)
src/strucvars/ingest/mod.rs 92% <ø> (ø)
src/seqvars/ingest/mod.rs 89% <0%> (+<1%) ⬆️
src/seqvars/prefilter/mod.rs 83% <85%> (+2%) ⬆️
src/common/noodles.rs 44% <8%> (-7%) ⬇️

... and 5 files with indirect coverage changes

@holtgrewe holtgrewe merged commit 06334e6 into main Jun 6, 2024
7 of 8 checks passed
@holtgrewe holtgrewe deleted the fix-custom-endpoint branch June 6, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant