Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treeshaking working? #33

Closed
jaulz opened this issue Nov 2, 2021 · 3 comments
Closed

Treeshaking working? #33

jaulz opened this issue Nov 2, 2021 · 3 comments

Comments

@jaulz
Copy link
Contributor

jaulz commented Nov 2, 2021

While checking the output of the compilation I noticed that variantjs exports all components and not only those which are really used. Not super important but just something I noticed 馃槉
@alfonsobries
Copy link
Contributor

@jaulz yes it's something that I am not able to fix yet, decided to leave that until the library is ready, I think it will require some work from the user side but not entirely sure yet. Vuetify for example require a couple of steps

@alfonsobries
Copy link
Contributor

Moving this to a task https://github.com/variantjs/vue/projects/1#card-73677924

@jaulz
Copy link
Contributor Author

jaulz commented Nov 26, 2021

Yeah, definitely not a show stopper since the library is anyway not super huge from a size perspective. Will at some point anyway need to investigate it and let you know about my findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaulz @alfonsobries