Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge bug // suggestions #2

Closed
jaylac2000 opened this issue Feb 19, 2020 · 4 comments
Closed

Huge bug // suggestions #2

jaylac2000 opened this issue Feb 19, 2020 · 4 comments

Comments

@jaylac2000
Copy link

jaylac2000 commented Feb 19, 2020

Bug:

I know this was reported already in #1 but also adding more suggestions to make it a better plugin

On a skyblock server you can use to sell on anyone's island which is a huge problem. you are gonna have to add in a feature so no one can use it in protected areas / zones / worlds if they dont have permissions to do anything there

3 Suggestions :

Make it so you can edit messages in config with color

ItemName: "&aSell Wand"
ItemLore: "&7Tap on a Chest to use"
NoSellableItems: "&cThere are no items to sell in this Chest"
SoldChest: "&a&lSuccess! &r&7sold the contents of the Chest for ยง8${MONEY}"

^^ Thats all base off the current code except you cant color coat the first 3 in the code (at least i cant figure it out...)

Add 2 more messages

GivenSellWand: "&7You have given {player} a sellwand"
ReceivedSellWand: "&7You have received a sellwand"

Also add in config what the sell wand item should be either by using the item name or id or either way

@iZeaoGamer
Copy link
Contributor

iZeaoGamer commented Feb 20, 2020

Hey. You can grab this Pull request build which should fix your issue.
Download it here: https://poggit.pmmp.io/r/76541/SellWands_pr-1.phar

@jaylac2000
Copy link
Author

Thank you @iZeaoGamer

@jaylac2000
Copy link
Author

add ally for /sellwand and make it /sw

@varunbln
Copy link
Owner

varunbln commented Mar 8, 2020

Added in latest commit

@varunbln varunbln closed this as completed Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants