Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy_scope: Don't alter query structure #749

Closed
wants to merge 1 commit into from

Conversation

jamesst20
Copy link

@jamesst20 jamesst20 commented Nov 16, 2022

Explanation: #748

Edit: Just noticed the build failed. Likely because Pundit is not specific to ActiveRecord. Leaving it there just in case you have a better implementation in mind.

@Burgestrand
Copy link
Member

Hi! Thanks for the PR.

I believe this puts a dependency on scope having a specific API interface (.where(id: …)). Other than being a breaking change, it also makes Pundit less agnostic about what a scope can be. Because of this I'm choosing not to accept the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants