Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript typings #20

Closed
curtisy1 opened this issue Feb 5, 2019 · 6 comments
Closed

Add Typescript typings #20

curtisy1 opened this issue Feb 5, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@curtisy1
Copy link
Contributor

curtisy1 commented Feb 5, 2019

Would you be willing to add typings for Typescript to this project? If you don't mind, I'll try working on getting these to work while integrating vasern in my project.

@hieunc229
Copy link
Contributor

@curtisy1 Hi Alex, I do plan to add Typescript to this project. Though I won't be able to do it at this moment as I am focusing on developing its server.

In case you want to add Typescript into the project, I'd really appriciate it.
Let me know and be willing to help.

@curtisy1
Copy link
Contributor Author

curtisy1 commented Feb 6, 2019

Alright, I'll start working on this today and submit a WIP pull request once I have some typings going so you can make comments on eventual coding guidelines I should adhere to

@hieunc229
Copy link
Contributor

hieunc229 commented Feb 6, 2019

Great @curtisy1, thank you! Just a note, all the JavaScript code are in vasern/vasern/src.

Let me know if you need anything to get started

@hieunc229
Copy link
Contributor

Hi @curtisy1, in case you need any help, please let me know. Or send me a message through our slack channel. I'm on Slack pretty often.

Cheers!

@hieunc229 hieunc229 added the enhancement New feature or request label Feb 13, 2019
@curtisy1
Copy link
Contributor Author

Sure thing! I'm almost done with the typings. Just need to iron out some conditions that I'm not quite sure about by testing each feature in an example database. I'll definitely contact you through Slack when I have questions.

@hieunc229
Copy link
Contributor

Nice works @curtisy1. I have also added you as our contributors.

Since it is added to the repo, I'll close this issue and feel free to open again or create a new issue

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants