Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Decouple SimpleEdgeStream and GraphWindowStream from neighbor stream keying #27

Open
drfloob opened this issue Oct 3, 2016 · 0 comments

Comments

@drfloob
Copy link

drfloob commented Oct 3, 2016

Right now, GraphWindowStream claims to operate over vertex neighborhoods, but that's only the case because SimpleGraphStream instantiates GraphWindowStreams with streams keyed by a NeighborKeySelector.

SimpleGraphStream#slice would be more valuable if it did not exclusively key streams in this way. For example, I think the aggregating Connected Components example could benefit from GraphWindowStream#slice if it allowed keying the stream arbitrarily (i.e. by subtask index).

GraphWindowStreams do not necessarily operate on neighborhoods, only coincidentally. One option is to rename this class and alter it to control the stream keying itself, to enforce its neighbor operation claims.

@drfloob drfloob changed the title [Discuss] Decouple SimpleEdgeStream and GraphWindowStream from neighborhood stream keying [Discuss] Decouple SimpleEdgeStream and GraphWindowStream from neighbor stream keying Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant