Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi I found the 6.5.0 vasl mode make the mistake #647

Closed
xigema opened this issue Apr 18, 2020 · 12 comments
Closed

Hi I found the 6.5.0 vasl mode make the mistake #647

xigema opened this issue Apr 18, 2020 · 12 comments

Comments

@xigema
Copy link

xigema commented Apr 18, 2020

chinese army,north korea set as Axis OOB

I suggest that put all the FW module in the FW OOB as well.

thanks

@derimmer
Copy link
Contributor

Personally, I think a better solution would be to rename the Allied OB tab Allied/UN OB and to rename the Axis OB tab Axis/Communist.

@xigema
Copy link
Author

xigema commented Apr 18, 2020

thanks for reply. I think that would not be a good ones for the Tab.I guess maybe this is for program settings.So may i ask if what could i do things for helping as that would be a single tap as Communist OB and UN OB.thanks.

@derimmer
Copy link
Contributor

VASL is an open source tool so you are free to make changes to it as you wish. See the Wiki tab at the top of the screen for instructions on how to get started. I would also suggest that you look at the VASSAL design guide on the VASSAL site as you will probably need to use the VASSAL editor to edit the VASL module. If you want changes available to the wider community you should push changes to this github repository as explained on the wiki.

@zgrose
Copy link
Contributor

zgrose commented Apr 18, 2020

Axis / Communist is going to make for a needlessly long tab name, IMO. I liked Axis / Allies / FW myself but I agree that the Axis/Allies labeling is pervasive (e.g. SAN) so having the mapping at the top of the counter hierarchy helps orient the user to what to expect in the rest of the system.

@bkemp01
Copy link
Contributor

bkemp01 commented Apr 19, 2020

Renaming the top level allied/axis o/b tabs breaks every extension that adds counters to an existing o/b. As @zgrose said the use of allied/axis is pervasive within VASL. This either needs to be left alone or the KFW forces moved to a completely separate tab structure.

@zgrose
Copy link
Contributor

zgrose commented Apr 19, 2020

I thought VASSAL assigned IDs to elements, but looking through the buildFile I see that is only the case for pieces. I agree, that pretty much kills changing the tab labels.

@xigema
Copy link
Author

xigema commented Apr 20, 2020

thanks to all. I have done some test about this issue.Result is like below:
(My changed to FW oob tap is name 6.5.0S)
1.in 6.5.0S it is seen that load a map need to choose the map twice. In 6.5.0 and 6.4.3 is OK.
2.in 6.5.0S that Sniper is not used.

I guess R1 is not known for reason and I need your help.
And in R2 as the Set Scenario Information is only can type Axis/Allied so the problem is found there maybe.

So that It seems to be a big case to fit that problem.Need more ways to think about it.

@derimmer
Copy link
Contributor

I think we can all agree that renaming the Allied O/B tabs and Axis O/B tabs is not the right way to go and would create more problems than it solves.

That leaves what to do about the KFW counters. Moving them to a completely separate tab structure is doable but is a lot of work that would be prone to errors.

In the interim players can continue to use the KFW extension if they prefer its structure to the 6.5.0 organization.

@zgrose
Copy link
Contributor

zgrose commented Apr 20, 2020

If you edit the XML directly, I don't think it would be that bad to move them around. I'll try to take a first pass at the process this week.

@derimmer
Copy link
Contributor

@zgrose I am just about to push up to github changes that will fix the minor counter errors founds so far (missing images mainly). That will include a new version of the buildFile. I would suggest using this new version.

@zgrose
Copy link
Contributor

zgrose commented Apr 20, 2020

Yup, I was more going to validate that we could simply cut and paste my way to #winning before I really sat down and did it. I will use the most current buildFile.

@xigema
Copy link
Author

xigema commented Apr 21, 2020

Thanks many to you both. I could think that would be a hard work for the legecy settings. It is hard to learn program in Java for me,because my work is using the Unity3d Tools to program for colleges.I would be happy to accept ,If you could give me some ways of doing on this project,Thanks

@derimmer derimmer closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants