Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invitation to transfer this package to nuxt-community #14

Open
pimlie opened this issue Oct 9, 2019 · 9 comments
Open

Invitation to transfer this package to nuxt-community #14

pimlie opened this issue Oct 9, 2019 · 9 comments

Comments

@pimlie
Copy link

pimlie commented Oct 9, 2019

Hi @vaso2,

Would you maybe be willing to transfer this package to the https://github.com/nuxt-community organisation? You will become a member of nuxt-community ofc as well, let me know and I will make the proper arrangements.

That way there are more people who could help you maintain this package and it would really become the de facto standard fontawesome integration package for Nuxt. Eg we could also publish it as @nuxtjs/fontawesome

@RonWalker22
Copy link

@vaso2 any plans on doing this?

@vaso2
Copy link
Owner

vaso2 commented Oct 31, 2019

@pimlie @RonWalker22 Greetings! Thanks for the invitation, I really appreciate this. It took me a long time to consider that. But before I can make a choice, can you tell me more about exact terms? What level of actual authorship and control over this package I'll retain? First of all, I'm interested in that link at the bottom of README. Also, what I'll get as a member of nuxt-community, maybe there is a place where I can read about such things? For example, will I be able to update other packages quickly, without a general flow of waiting for someone to accept PR? More precisely I'm gonna write a plugin for Yandex Metrika soon because current @nuxtjs/yandex-metrika is completely useless:)
Thanks in advance!

@pi0
Copy link

pi0 commented Nov 1, 2019

@vaso2 Thanks for your interest and nice module ❤️ There is a package @nuxtjs/font-awesome which can be used/replaced with a major version bump to your code.

Regarding ownership, the module author (you) is always owner so you can freely make changes and doing releases. Nuxt core team checks the quality and status of community modules and making PRs or Issues for improvements and ensuring the module is not left unmaintained. in that cases, we try to contact with the author to decide what to do.

For doing changes or releases on other existing community modules that you didn't create, you need to ask permission from original authors. Also for creating/moving new modules, you need to confirm it with core team.

For specific yandex-metrika, that would be great if you want to take maintenance of it because it currently has not a maintainer! Just ping me on discord so we can talk about it :)


Backing to issue, the procedure is:

  • We add you to nuxt-community and NPM @nuxtjs org
  • The repo should be consistent with the official module-template. You can do that yourself or one of us can happily make a PR for it :)
  • You move the repo to nuxt-community and do an initial release (for this case, a major bump)

@pimlie
Copy link
Author

pimlie commented Jan 20, 2020

Because we unfortunately never heard back from @vaso2, we have forked this (font) awesome module under nuxt-community and made some small improvements. Check it out here: https://github.com/nuxt-community/fontawesome-module

@pimlie pimlie closed this as completed Jan 20, 2020
@vaso2 vaso2 reopened this Jan 21, 2020
@vaso2
Copy link
Owner

vaso2 commented Jan 21, 2020

Hi again, I’m here, all of it just got out of my mind because of high workload:( If someone is ready to be in touch I’m ready to make transition in nearest days
@pimlie ?

@pi0
Copy link

pi0 commented Jan 22, 2020

Hi @vaso2. Happy seeing you back again and no worries at all. High workload can always happen.

We was stock for a long time waiting for your decision so @pimlie made a rewrite on top of your awesome works in Nuxt community.

If you are still busy, please just make me (pi0) or pim admin for repository and NPM package. If it's OK with you we will deprecate current package and provide migration steps from nuxt-fontawesome to @nuxtjs/fontawesome

Cheers!

@vaso2
Copy link
Owner

vaso2 commented Jan 23, 2020

Hi there. Yep, please provide migration guide, cheers!

@pi0
Copy link

pi0 commented Jan 24, 2020

@vaso2 Pimlie already did module migration! So steps I would suggest:

Then either:

  • Add a note to readme advising users that latest version is here: https://github.com/nuxt-community/fontawesome-module and archive repository (will link back from new repo to keep all credits)
  • Make me the owner of this repo (from here) so we can transfer to keep stars and users will be auto redirected to nuxt-community

Finally, you will have commit/publish access to the new repo so no worries :)

@pimlie
Copy link
Author

pimlie commented Jan 24, 2020

@vaso2 Do you think you'll have time to look at the yandex-metrika module as you mentioned before? That would be really awesome too! (see what i did there 😄 )
If so, it would probably be best if you create a new temporary personal repository for it and when its ready to be released we then move that to nuxt-community and then deprecate this one: https://github.com/nuxt-community/modules/tree/master/packages/yandex-metrika

Glad to have you onboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants