Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pieces dropping through to window beneath... PieceMover.mouseReleased #9517

Closed
uckelman opened this issue Jun 28, 2021 · 6 comments
Closed

Comments

@uckelman
Copy link
Contributor

Bugzilla
ID BZ13780
Reported 2020-11-30 23:29:00 +0100
Modified 2020-11-30 23:29:40 +0100
Product VASSAL
Component Player
Version unspecified
Platform All
OS All
Status NEW
Resolution None
Priority unspecified
Severity normal
Milestone ---
Reporter Claudio Ciardelli
Assignee Bugs
Attachments
DragPiece on MapWindow close.pdf Claudio Ciardelli 2020-11-30 23:29:00 +0100 application/pdf 420450 Bug description and how to reproduce

Claudio Ciardelli 2020-11-30 23:29:40 +0100

Created attachment 12553
Bug description and how to reproduce

See attachment for a detailed description that should allow you to reproduce the issue.
I have done some debugging and I believe the cause of the problem with PieceMover.jave method mouseReleased.
I managed to reproduce the same behaviour on all the modules I tested (Vietnam, FITL and GTS).
@Cattlesquat
Copy link
Collaborator

@uckelman Attachment looks like it's there but I can't get at it?

@uckelman
Copy link
Contributor Author

@Cattlesquat It opens just fine for me when I click it. What happens when you try?

@Cattlesquat
Copy link
Collaborator

@Cattlesquat It opens just fine for me when I click it. What happens when you try?

@uckelman I click on it and nothing happens, opens, etc. I certainly don't normally have problems opening PDFs.

Oh interesting it opens in Firefox but not in Chrome which for whatever reason I was using for my Github rampage

@uckelman
Copy link
Contributor Author

uckelman commented Oct 26, 2021

It's possible that it has the wrong MIME type set on it in S3. As long as you can get it, it's probably not worth my screwing with that.

@Cattlesquat
Copy link
Collaborator

@uckelman Okay this is a 100% successful repro for me -- when I double-click the upper left corner widget to close the subwindow, double-click is properly registered by that window and closes it, but then that second click is passed through to the main map behind it and the main map acts as if I clicked or dragged to that location.

This feeeeels like a Java or Swing bug though - I can't imagine how we could ever fix that?

@Cattlesquat
Copy link
Collaborator

@claudiociardelli This is 100% reproducible for me on Windows, but because of the nature of where that faulty click is coming from (it's bleeding through from the Window decoration!), it is not so much a bug in VASSAL as a bug in the JVM or Swing. In other words impossible for us to fix, alas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants