Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors appropriately #12

Open
jw-s opened this issue Apr 20, 2018 · 0 comments
Open

Handle errors appropriately #12

jw-s opened this issue Apr 20, 2018 · 0 comments

Comments

@jw-s
Copy link
Collaborator

jw-s commented Apr 20, 2018

Currently we use the circuit braker pattern when sending payloads downstream to the coordinator.

We don't check the type of error and thus retry infinitely.

This "failed" request is placed In a queue and never forgotten unless it becomes successful. This won't happen if the failure is due to api incompatibilities or anything other than downstream service being unavailable.

@jw-s jw-s assigned jw-s and pgronkiewicz and unassigned pgronkiewicz and jw-s Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants