Weird XO Error Message When VM Started and All Servers Disabled

[evoelise]

XO from the sources

When an attempt to start a VM is done when all servers in the pool are disabled a weird error message is shown.

At first just a single letter is shown "g" when the VM is started, when the error is clicked to view in the error log then the following is shown - with the use name as the error.

It appears this happens as the actual error has no message:

vm.start
{
  "id": "122162af-de31-8a27-b78c-1**********f",
  "bypassMacAddressesCheck": false,
  "force": false
}
{
  "errors": [
    "XCPNG02: HOST_DISABLED(OpaqueRef:a1e9a8f3-0a79-4824-b29f-d**********0)",
    "XCPNG01: HOST_DISABLED(OpaqueRef:9ae9d4e6-3928-44c0-ad64-0**********e)",
    "XCPNG03: HOST_DISABLED(OpaqueRef:484dc396-2d90-497e-a35a-1**********c)"
  ],
  "message": "",
  "name": "Error",
  "stack": "Error: 
    at Xapi._startVm (file:///opt/xo/xo-builds/xen-orchestra-202206111352/packages/xo-server/src/xapi/index.mjs:880:15)
    at Xapi.startVm (file:///opt/xo/xo-builds/xen-orchestra-202206111352/packages/xo-server/src/xapi/index.mjs:916:7)
    at Api.callApiMethod (file:///opt/xo/xo-builds/xen-orchestra-202206111352/packages/xo-server/src/xo-mixins/api.mjs:310:20)"
}

[olivierlambert]

Hi,

1. It's normal since a host in maintenance mode will refuse to start any new VM
2. Indeed, the display is maybe problematic in that case. Pinging @Rajaa-BARHTAOUI to take a look.

[julien-f]

I believe simply passing an error message here should be enough:

xen-orchestra/packages/xo-server/src/xapi/index.mjs

Line 881 in 8c14906

throw new AggregateError(