Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups): fix size of NBD backups #6599

Merged
merged 3 commits into from
Jan 16, 2023
Merged

fix(backups): fix size of NBD backups #6599

merged 3 commits into from
Jan 16, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jan 2, 2023

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the fix_nbd_size branch 5 times, most recently from ada2fdb to fe0b422 Compare January 2, 2023 15:46
@fbeauchamp fbeauchamp force-pushed the fix_nbd_size branch 2 times, most recently from b6774bc to d056dfb Compare January 12, 2023 08:42
@fbeauchamp fbeauchamp marked this pull request as ready for review January 12, 2023 08:42
@julien-f julien-f changed the title fix(@xen-orchestra/backups): compute size of block based backups fix(backups): compute size of block based backups Jan 16, 2023
@julien-f julien-f changed the title fix(backups): compute size of block based backups fix(backups): fix size of NBD backups Jan 16, 2023
@julien-f julien-f merged commit a2d9310 into master Jan 16, 2023
@julien-f julien-f deleted the fix_nbd_size branch January 16, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants