Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone #7388

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Fix clone #7388

merged 2 commits into from
Feb 23, 2024

Conversation

julien-f
Copy link
Member

Do not squash, review by commit.

Description

  • fix(xo-web/new-vm): respect fast clone setting
  • fix(xo-web/new-vm): handle both template_info.disks and VDIs

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@julien-f
Copy link
Member Author

Fix as been confirmed to work by an user.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Show resolved Hide resolved
@pdonias pdonias merged commit 5d82f26 into master Feb 23, 2024
1 check passed
@pdonias pdonias deleted the fix-clone branch February 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants