Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent being able to depend on a library that's not declared in artifacts.bzl #269

Open
lolski opened this issue Mar 4, 2021 · 0 comments

Comments

@lolski
Copy link
Member

lolski commented Mar 4, 2021

Right now, it is possible for packages inside Grakn Core to depend on libraries declared in artifacts.bzl of other repositories.

For example, take the following example where Grakn Core also needs to load artifacts.bzl from Grabl Tracing:

load("//dependencies/maven:artifacts.bzl",
graknlabs_grakn_core_artifacts = "artifacts")
load("@graknlabs_grabl_tracing//dependencies/maven:artifacts.bzl",
graknlabs_grabl_tracing_artifacts = "artifacts")
load("@graknlabs_dependencies//library/maven:rules.bzl", "maven")

maven(
        graknlabs_grabl_tracing_artifacts +
        graknlabs_grakn_core_artifacts,
)

There's nothing that prevents Grakn Core to load Maven packages declared in the artifacts.bzl coming from Grabl Tracing. This is not ideal since Grakn Core should only be able to depend on Maven dependencies explicitly declared in artifacts.bzl.

lolski pushed a commit to lolski/dependencies that referenced this issue Oct 7, 2022
…ft as well as a published release (typedb#269)

## What is the goal of this PR?

We have added a `draft` parameter to `deploy_github`. If it is set to `True`, the rule will create a release that is marked as draft. When set to `False`, the release will be immediately published.

This is an improvement of the existing behaviour, in which you can only create a draft release.

## What are the changes implemented in this PR?

- Implement the `draft` field
- Refactor the rule and `deploy.py` template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant