Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nodejs compilation from genrule to full bazel rule #80

Open
Phillammon opened this issue Dec 1, 2020 · 1 comment
Open

Refactor nodejs compilation from genrule to full bazel rule #80

Phillammon opened this issue Dec 1, 2020 · 1 comment

Comments

@Phillammon
Copy link

Problem to solve
The nodejs genrule is cumbersome, and also requires exposing the raw .proto files with a filegroup instead of accessing via the proto_library rules provided.

Proposed solution
Rewrite the genruled as a full fledge bazel rule, including accessing the source files via proto_library.src_file, and delete the associated filegroup from the /proto/BUILD file

@flyingsilverfin
Copy link
Member

flyingsilverfin commented Jan 10, 2023

This is still a valid issue and represents a significant awkwardness in the NodeJS protobuf compilation process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants