Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Design Changes for OrderDeliverer #1

Open
vaughnshaun opened this issue Jun 7, 2019 · 0 comments
Open

Make Design Changes for OrderDeliverer #1

vaughnshaun opened this issue Jun 7, 2019 · 0 comments

Comments

@vaughnshaun
Copy link
Owner

Based on a review done by dfhwze of codereview.stackexchange there are some basic code snippets that need to be changed. The full review can be found at https://codereview.stackexchange.com/questions/221757/drone-delivery-scheduling-service/221761#221761. The changes are listed below.

  1. Public facing methods should have guard clauses.
  2. Keep nested if statements to a minimum.
  3. Avoid redundant comments. Only add comments if it adds new information to the code.
  4. Inline variable declaration. This is useful for out arguments.
  5. Avoid redundant variable type. Use var.
  6. Event lifetime management. Events should be unsubscribed.
  7. Only use virtual methods if there is a reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant