Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to update to the latest vavr version? #20

Open
timmattison opened this issue Oct 22, 2020 · 7 comments
Open

Any plans to update to the latest vavr version? #20

timmattison opened this issue Oct 22, 2020 · 7 comments

Comments

@timmattison
Copy link

Are you accepting and merging PRs for it? It would be nice to use Vavr 0.10.3 in GWT.

@nfekete
Copy link
Member

nfekete commented Oct 22, 2020

Hello Tim! Yes, I can review them and have them merged. I haven't used vavr with GWT for a while now (I think since about 0.9.2). How many changes do you see are required to have it working?

@timmattison
Copy link
Author

I'm not sure yet. I haven't had time to dig into it. Primarily some tests are broken because Vavr removed some Future methods. I think if those tests were removed it would be pretty close to done.

@timmattison
Copy link
Author

I took a shot at updating this and I think I got it working for the most part but one of the things that I noticed, even with version 0.9.2, is that my build time went from 30s to multiple minutes as soon as I included Vavr GWT. Is that normal? Are there any ways to reduce that?

@nfekete
Copy link
Member

nfekete commented May 19, 2021

@timmattison What GWT compiler version were you using? In the current master version of the vavr-gwt module, the declared GWT dependency version is 2.8.2, which is from 2017, so it's quite old. Slow compilation in GWT is usually the result of the Eclipse Compiler for Java (ECJ) embedded by GWT being very slow for code which is heavy on generics, and vavr has some parts — especially the API class —, which is triggering this behavior.

There's a newer GWT version 2.9.0 from 2020, which improves the build time significantly. I just tried to build the 0.9.2 version of vavr-gwt with GWT 2.9.0 and the build time went down from ~100 second to ~30 seconds. Can you try it out in your build?

@timmattison
Copy link
Author

I tried again but I was getting builds so long they never finished. Maybe something with my config.

Any chance I could donate to get vavr-gwt updated to the latest vavr version (0.10.3)? I've gotten so used to it I can't live without it. :) And being able to use it in my client code would be incredible.

@timmattison
Copy link
Author

I tried again, again today. :P Here's what I ran into...

With the latest version here, 0.9.2, I get an initial build time of 7 minutes and then recompiles are generally fast enough for me to not be bothered by it (~30 seconds).

With my version of 0.10.3 - timmattison@5dbfb92 - I've had it running in the compile-gwt stage for over two hours and it's showing no signs of stopping.

Thoughts?

@nfekete
Copy link
Member

nfekete commented Jul 16, 2021

@timmattison what are you trying to compile when you get this very long/stuck build? Because the GWT compilation time for vavr + running the test suite is pretty decent for me (the times I listed in my earlier comment), so it might be something to with your project maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants