Allows material BoolFields to be checkboxes or toggles #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if appearance set to 'toggle'. Default or any other value is 'checkbox' (present behavior) Updated combined tests for the above
radekmie
suggested changes
Feb 10, 2017
| @@ -7,6 +7,7 @@ import {spy} from 'sinon'; | |||
| import {stub} from 'sinon'; | |||
|
|
|||
| import MaterialCheckbox from 'material-ui/Checkbox'; | |||
| import MaterialToggle from 'material-ui/Toggle'; | |||
| @@ -1,4 +1,5 @@ | |||
| import Checkbox from 'material-ui/Checkbox'; | |||
| import Toggle from 'material-ui/Toggle'; | |||
| @@ -11,18 +12,28 @@ const Bool = ({ | |||
| name, | |||
| onChange, | |||
| value, | |||
| appearance = 'checkbox', | |||
There was a problem hiding this comment.
Props also should be sorted.
| name={name} | ||
| onCheck={(event, value) => disabled || onChange(value)} | ||
| ref={inputRef}{...filterDOMProps(props)} | ||
| />); |
There was a problem hiding this comment.
Two things here:
- keep props sorted
- ternary should be formatted like this:
appearance === 'toggle' ? (
<Toggle
...
/>
) : (
<Checkbox
...
/>
)
|
Great! And I'm really glad to see, that you've written tests! |
…mbined.js Update: Formatting of ternary expression in BoolField.js
|
Updated. |
radekmie
approved these changes
Feb 10, 2017
|
Yeah, I have to update ESLint finally... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an appearance property to BoolField that allows rendering as a Toggle if appearance set to 'toggle'. Default or any other value is 'checkbox' (present behavior) so as to not break any existing apps.
That is,
<BoolField name='field' />still works as it previously did by rendering a checkbox, but now you can alternatively use toggles:<BoolField name='field' appearance='toggle' />Updated combined tests for the above (x35)
NOTE: I did not update any package version numbers.