Regression with rc.16

[serkandurusoy]

On rc.15

<TextField type="password" name="password">

renders a password field, but on rc.16 this renders a normal input field.

It seems like the changes introduced by commit 6b0ed46 where we set

type={typeof props.type === 'function' ? 'text' : props.type}

instead of

type={props.type || 'text'}

is the root cause.

[radekmie]

Yes, I've made this, because every field already receives a type prop - it's the type from schema (SimpleSchema at least).

type={typeof type === 'string' ? type : 'text'}

should do the job.

[radekmie]

Fixed in 1.0.0-rc.17.

[macrozone]

Isn't the type from the schema usually something like String, Number, Object, Array, etc?

I think we should distinguish between both "types" better. E.g. name one "htmlType" (or "inputType" or whatever) and the other "schemaType" or so. It's not obvious which type you currently have, if you are about to design a Form-component. I think its good to be explicit here.

If you would want to force a type in the schema you would probably want to do one of the following:

text: {
  type: String,
  uniforms: {
     htmlType: "password"
  }
}

or

text: {
  type: String,
  uniforms: {
     component: PasswordField
  }
}

(...)
const PasswordField = (props) => <TextField htmlType="password" {...props} />

If htmlType is not set, you would "guess" it from the schemaType:

const htmlType = typeof schemaType === Number ? "number" : "text"

[radekmie]

I thought about renaming schema type to fieldType, because only AutoField uses it.

[serkandurusoy]

type is the correct prop for html input elements within the context of JSX therefore instead of renaming it, we should make it so that this is context aware.

Such that;

perhaps the type from the schema gets translated into an internal schemaFieldType property and type from the prop or uniforms key gets translated into an internal htmlInputFieldType

[serkandurusoy]

@radekmie it seems rc.16 has not been published to npm yet

[radekmie]

No, 1.0.0-rc17 is already published, but there were no changes in uniforms itself, so it stays in 1.0.0-rc.16.