Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/Previous page buttons become focused and display tooltips incorrectly in certain situations #696

Closed
alcatrazEscapee opened this issue Nov 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@alcatrazEscapee
Copy link
Contributor

Mod loader

Forge

Minecraft version

1.20.1

Patchouli version

1.20.1-81

Modloader version

Forge 47.1.3

Modpack info

No response

The latest.log file

https://gist.github.com/alcatrazEscapee/b18259bf60b51fd627dc19dca0a6fbf3

Issue description

The "Next" and "Previous" buttons sometimes have sticky tooltips:

image

This is behavior that intentionally occurs when using the Tab key to cycle through buttons, but occurs without that as well, with specific combinations of keys and/or scrolls. It occurs more frequently in longer books with more pages per entry.

Steps to reproduce

Example 1

  1. Open the "comprehensive_test_book" included in Patchouli
  2. Click "Builtin Page Types"
  3. Click "Spotlights"
  4. Click "Next"
  5. Bug The "Next" button is still isFocused() and the tooltip moves around the page.
  6. Click "Next"
  7. Click "Previous"
  8. Bug The "Previous" button is still isFocused() and the tooltip moves around the page.

Video:

Minecraft.Forge_.1.20.1.-.Singleplayer.2023-11-01.21-13-23.mp4

Example 2

  1. Open the "comprehensive_test_book" included in Patchouli
  2. Click "Builtin Page Types"
  3. Click "Spotlights"
  4. Scroll to the next page
  5. Press "Previous"
  6. Scroll to the next page
  7. Bug: The "Previous" tooltip appears, with the previous button still being isFocused()

Video:

Minecraft.Forge_.1.20.1.-.Singleplayer.2023-11-01.21-15-56.mp4

Other information

No response

@alcatrazEscapee alcatrazEscapee added the bug Something isn't working label Nov 2, 2023
alcatrazEscapee added a commit to alcatrazEscapee/Patchouli that referenced this issue Nov 2, 2023
alcatrazEscapee added a commit to alcatrazEscapee/Patchouli that referenced this issue Nov 2, 2023
Better fix that doesn't CME when entries with many pages are clicked too fast. Previous fix caused other buttons to still iterate after one was handled, rather than returning and just handling the last widget.
@alcatrazEscapee
Copy link
Contributor Author

Fixed by 3e9a848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant