Skip to content

Commit

Permalink
small language change for autodetect in max frame gap vignette
Browse files Browse the repository at this point in the history
  • Loading branch information
scienceisfiction committed Dec 30, 2020
1 parent bcf6424 commit 62b63b7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
5 changes: 2 additions & 3 deletions example_scripts/ropensci_reviews_checklist.html
Original file line number Diff line number Diff line change
Expand Up @@ -439,13 +439,12 @@ <h4>Managing frame gaps</h4>
<p>Very minor point: could it be clearer in the visualize_frame_gap_choice() help or in the vignette that the loops argument represents the maximum frame gap considered (i.e. that each loop represents an increment of 1 on the frame gap value)?</p>
</blockquote>
<p>Items for us:<br />
- [ ] add details to vignette<br />
- [ ] add details to Help file</p>
- [x] add details to vignette <a href="https://github.com/vbaliga/pathviewR/commit/bcf64241867e6da0c96181a4ed11379c4eb5b646">(bcf6424)</a> - [x] add details to Help file <a href="https://github.com/vbaliga/pathviewR/commit/bcf64241867e6da0c96181a4ed11379c4eb5b646">(bcf6424)</a></p>
<blockquote>
<p>Could there be cases when frame gaps can vary between devices (i.e. if I understood well in the case of the Motive data, between subjects)? If so, would it be relevant to allow the autodetect approach to be applied to each subject separately? (or maybe that is not relevant…)</p>
</blockquote>
<p>Items for us:<br />
- [ ] do we not already do this? Let’s look into it. If we already do, let’s see if we can make it clearer in the vignette.</p>
- [ ] we already do this. add example in the vignette</p>
</div>
<div id="visual-perception" class="section level4">
<h4>Visual perception</h4>
Expand Down
4 changes: 2 additions & 2 deletions example_scripts/ropensci_reviews_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ considered (i.e. that each loop represents an increment of 1 on the frame gap
value)?

Items for us:
- [ ] add details to vignette
- [ ] add details to Help file
- [x] add details to vignette [(bcf6424)](https://github.com/vbaliga/pathviewR/commit/bcf64241867e6da0c96181a4ed11379c4eb5b646)
- [x] add details to Help file [(bcf6424)](https://github.com/vbaliga/pathviewR/commit/bcf64241867e6da0c96181a4ed11379c4eb5b646)

> Could there be cases when frame gaps can vary between devices (i.e. if I
understood well in the case of the Motive data, between subjects)? If so, would
Expand Down
6 changes: 3 additions & 3 deletions vignettes/managing-frame-gaps.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ Setting `max_frame_gap = "autodetect"` rather than a numeric value uses the
value(s) for `max_frame_gap`. In addition to automatically selecting the
`max_frame_gap` depending on the data, "autodetect" does so on a per subject
basis rather than applying the same allowable frame gap to all data in the data
set. The cap on how high the `max_frame_gap` can go is defined as a proportion
of the capture frame rate and set by the `frame_rate_proportion` argument, which
defaults to `.10`.
set since frame gaps can vary between subjects. The cap on how high the
`max_frame_gap` can go is defined as a proportion of the capture frame rate and
set by the `frame_rate_proportion` argument, which defaults to `.10`.

```{r max_frame_gap_auto}
motive_auto <-
Expand Down

0 comments on commit 62b63b7

Please sign in to comment.