New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in weight standardization? #35

Closed

jamestwebber opened this issue May 4, 2021 · 1 comment

jamestwebber commented May 4, 2021 •

edited

Loading

Pretty sure this should be

fan_in = torch.prod(torch.tensor(self.weight.shape[:-1]))

edit: bug in my suggestion!

Owner

vballoli commented May 4, 2021

I believe it's fine. Feel free to re-open or add to the discussions!

vballoli closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment