relax trait requirements for binary operations. #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Would you mind rebasing on master to include the clippy lint fixes? |
|
Sorry for the late reply.
Sure! |
taketo1024
force-pushed
the
relax_trait_restr
branch
from
f139c18
to
23af97f
Compare
|
I have rebased |
|
Thanks for this PR @taketo1024! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #319, I have relaxed the trait requirements for
Add,Subetc forCsVec, so that in particular we can add and subtract vectors with scalar types that does not necessarily implement thenum_traits::Numtrait.