-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxywriter #52
Comments
Hello! |
I've done this externally in a library I wrote to wrap |
I think the title of the issue is a bit misleading, because @donny-dont asked for @nektro thanks for interesting code, anyway. |
The
io.Copy
function has optimizations where the Reader implementsio.ReadFrom
.For example
sftp.File
implementsio.ReadFrom
. So if you attempt to download a file fromsftp
and wrap it with ampb.proxyReader
thenio.Copy
is unable to use theio.ReaderFrom
optimization.I was thinking about migrating from https://github.com/cheggaaa/pb to mpb since it has multiple progress bar support and noticed that mpb just proxies a reader. Would it be of interest to do a writer proxy as well?
The text was updated successfully, but these errors were encountered: