Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal组件请加上父级样式,不然会导致第三方组件modal样式错乱 #3582

Closed
sscfaith opened this issue Jan 30, 2024 · 3 comments
Labels

Comments

@sscfaith
Copy link

sscfaith commented Jan 30, 2024

Subject of the feature

框架修改了antdv的Modal组件,但是没有加上父级样式,导致第三方组件里使用的modal样式错乱。

Problem

框架修改了antdv的Modal组件,但是没有加上父级样式,导致第三方组件里使用的modal样式错乱。

Expected behaviour

请不要修改antdv全局样式,保证第三方组件antdv样式正确。

Alternatives

BasicModal组件加上class,index.less中ant-modal的样式使用class包裹。
不知道这次commit为什么要去掉父级class。

@xachary
Copy link
Contributor

xachary commented Jan 31, 2024

@sscfaith 你的提议我觉得是合理的,只是我看现在全局样式被改(没有隔离)的挺多,尴尬。

@xachary
Copy link
Contributor

xachary commented Feb 1, 2024

没有隔离的.ant-样式,大概有这些:
src\components\Modal\src\index.less
src\design\ant\btn.less
src\design\ant\index.less
src\design\ant\input.less
src\design\ant\pagination.less
src\design\ant\popconfirm.less
src\design\theme.less

@anncwb
Copy link
Collaborator

anncwb commented Apr 9, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@anncwb anncwb added the Stale label Apr 9, 2024
@anncwb anncwb closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants