Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile and test out of box fail? #5

Open
jstott opened this issue Jul 28, 2017 · 1 comment
Open

compile and test out of box fail? #5

jstott opened this issue Jul 28, 2017 · 1 comment
Labels

Comments

@jstott
Copy link

jstott commented Jul 28, 2017

So after a clean clone - both compile and test fail? [Windows, node v8.x / npm v5.3 / ts v2.4.2]
Obviously some issues with isomorphic-fetch, but assume you are running the same for publish - something missing here? TIA.

Output

npm i
npm run test
ERROR: 52796:119  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 52833:116  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 52871:153  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 52916:146  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 52960:133  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 53001:24   typedef-whitespace  expected nospace before colon in property-declaration
ERROR: 53014:126  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 53055:231  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 53111:117  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 53148:114  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 53186:151  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 53231:150  typedef-whitespace  expected nospace before colon in call-signature
ERROR: 53275:137  typedef-whitespace  expected nospace before colon in call-signature

D:/VSTS-Sandbox/connectwise-rest-api/src/connectwise.ts
ERROR: 319:98     semicolon           Missing semicolon

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! connectwise-rest-api@1.2.1 test: `tslint --project tsconfig.json --format stylish && tsc --pretty --noEmit && ava`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the connectwise-rest-api@1.2.1 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm run compile

node_modules/@types/isomorphic-fetch/index.d.ts(66,14): error TS2403: Subsequent variable declarations must have the same type.  Variable 'referrerPolicy' must be of type 'ReferrerPolicy', but here has type 'string'.


67     readonly type: string;
                ~~~~

node_modules/@types/isomorphic-fetch/index.d.ts(67,14): error TS2403: Subsequent variable declarations must have the same type.  Variable 'type' must be of type 'RequestType', but here has type 'string'.


94     readonly type: string;
                ~~~~

node_modules/@types/isomorphic-fetch/index.d.ts(94,14): error TS2403: Subsequent variable declarations must have the same type.  Variable 'type' must be of type 'ResponseType', but here has type 'string'.

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! connectwise-rest-api@1.2.1 compile: `tsc --pretty`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the connectwise-rest-api@1.2.1 compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
@sowderca sowderca self-assigned this Jul 28, 2017
@sowderca sowderca added the bug label Aug 2, 2017
@sowderca
Copy link
Contributor

sowderca commented Aug 4, 2017

@jstott, Yes I had to work around this for the last release. As you noticed the issue is with the typings pulled from isomorphic-fetch. I'll push an update to fix.

Also some linting issues with ts-lint.

@sowderca sowderca removed their assignment Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants