-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual keyboard with autorepeat #161
Comments
Hi @Vweber73 I have ported the upgraded virtual keyboard from vAmigaWeb ... what I saw is that the initial basic screen did only auto repeat some keys cursor space and del key... other keys were not repeated despite an emulated long press duration... you could launch the program "anykey" via the integrated csdb browser... open snapshot and select there as a source "csdb" now you can search for "anykey" this is a keyboard test program ... in any key you could see the real press time... |
Hi, Many thanks ! I have just tested it with the best possible test - Fighter Pilot ! Also: Many thanks and best regards |
Also: |
fixed 😎 those were special because they do not really exists on a c64 keyboard ... it is always a combination with shift and the opposite direction e.g. shift + ArrowRight for ArrowLeft . I think I fixed it now... |
Works well, many thanks ! :) |
should we open a separate issue ? I found this when I searched for how to programmatically change the display setting in a PWA https://stackoverflow.com/questions/53048372/how-to-programmatically-switch-display-from-standalone-to-fullscreen-in-pwa
we should address this in a separate issue too... BTW is this reproducable ? or is it more like random ... sometimes sound fails to come back ? I close this issue ok ? If there is still anything wrong we could reopen it... |
Hi, |
hm ... on iPhone I cannot scroll on key caps in "exact timing" mode... how about vAmigaWeb on the z3 does it scroll there too ? for the others lets make separate issues... I think I have to properly disconnect audio when it suspends ...I do not see this in iOS but this is maybe a bit OS specific some do handle this more robust than other ... when there is something as a suspend event then I could shut down sound ... we will address this in a separate issue what you think? status bar too... do you open ? |
On my Z3 vAmigaWeb has neither the keyboard scroll issue nor the sound issue, they are specific to vc64Web. |
I found one difference between vAmigaWeb and vc64web codewise ... maybe that was the missing piece on the z3 ? Despite that I do not see this behaviour on iPhone and also not on a Windows11 with a touchscreen ... I merged the spotted difference into vc64web... maybe it fixed it ? |
It didn't, but sorry, I think i said something wrong. I tested again vAmigaWeb, and I could also scroll the keyboard with J and K keys. I suspect it is because since the Z3 is large, it could detect a gesture on the small empty space between the keys. Maybe the same on Ipad ? |
with "exact timing"... Yes it could happen that a finger near the gap space between two key caps can trigger a native scroll ... but that is not that bad or am I wrong ? The goal was NOT to disable the native scroll on key caps ... instead the goal was to free the key caps from all standard gestures (like context menu and text selection, drag and drop, scroll swipe ...) to get an ultra responsive keyboard 😎 ... as a side effect well the native scroll on key caps is no more ... so when it comes back partially because the browser engine/host OS thinks a finger is touching near a gap then I think this is totally fine for us ... I think the most important thing is that the key cap press/release is registered very accurate/exact |
Yes it is fine, no big deal ! :) |
with "mixed of both" we implemented an own gesture detection on key cap to be able to detect an intended scroll ... at the same time we trigger exactly at the same time a key press ... disadvantage here when we know that it is only an intended scroll we could not revoke the key press ... but the advantage is we are super fast when a key press is intended as we do away with all the native gesture thinking and evaluating |
I tried vc64web on my tiny ipod... Upon trying to move the keyboard (gigantic for the device), I got a sticky message on top of the screen: "exception thrown. See JavaScript console", although everything seems to continue to work... |
good catch ... tomorrow I will look into it ... today I did the support for exporting dh0 as hdf file see here vAmigaWeb/vAmigaWeb#86 I am so glad that this feature works so well ... playing monkey island hd version and I can save game state to hd and then I am able to export ... can import to winuae, fsuae, vAmiga or others so cool 😎 |
Excellent ! :) Only lacking is multi-drive support :) |
it does appear when keyup event fires on lowercase/uppercase key thanks for reporting ... fix comes soon |
Perfect, thanks ! |
fixed 😎 |
Hi,
Could the changes done for vAmigaWeb keyboard could be done as well for vc64web ?
Thanks and cheers
The text was updated successfully, but these errors were encountered: