Fix for when reveal views have clickable control #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if we added a button with its `setOnClickListener` it will crash if we attempt to swipe (left or right) by starting with our finger directly over the button. Although the button is "hidden" behind the "front" view. So this fix is mainly to keep both the reveal panels invisible (`GONE`) when then "front" view is covering them completely. I think this is probably what most developers would expect the default behavior to be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if we added a button with its
setOnClickListenerit will crash if we attempt to swipe (left or right) by starting with our finger directly over the button. Although the button is "hidden" behind the "front" view.So this fix is mainly to keep both the reveal panels invisible (
GONE) when then "front" view is covering them completely. I think this is probably what most developers would expect the default behavior to be.