Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dockerimmugw #24

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Fix/dockerimmugw #24

merged 1 commit into from
Feb 20, 2020

Conversation

mmeloni
Copy link
Contributor

@mmeloni mmeloni commented Feb 19, 2020

In dockerfile is missing immugw.
Remove useless host param

@mmeloni mmeloni requested a review from leogr February 19, 2020 17:17
leogr
leogr reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but "host" should be kept IMHO - unless we have a specific reason

cmd/immugw/immugw.go Outdated Show resolved Hide resolved
leogr
leogr approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leogr leogr merged commit 10f00eb into codenotary:master Feb 20, 2020
gitbook-com bot pushed a commit that referenced this pull request Jan 3, 2022
@gitbook-bot
GitBook: [#24] No subject
07698cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmeloni @leogr