Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bind psql port to the same IP address as grpc interface #867

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

SimoneLazzaris
Copy link
Collaborator

I've found a weird behavior of immudb, specifically the psql port.

If I ask immudb to bind to a specific IP address (i.e. --address 127.0.0.2) I find only 3 out of 4 port bind are actually made to that interface:

$ ss -plnt|grep immudb
LISTEN 0      0          127.0.0.2:9497       0.0.0.0:*    users:(("immudb",pid=458586,fd=26))   
LISTEN 0      0          127.0.0.2:3322       0.0.0.0:*    users:(("immudb",pid=458586,fd=24))   
LISTEN 0      0          127.0.0.2:8080       0.0.0.0:*    users:(("immudb",pid=458586,fd=27))   
LISTEN 0      0                  *:5432             *:*    users:(("immudb",pid=458586,fd=25))   

Port 5432 is always binding to every interface.

That prevents me to (easily) launch to instance on the same machine, binding the first one on (say) 127.0.0.2 and the other on 127.0.0.3.

This PR binds psql port on the very same address of the others ports.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.02%) to 89.858% when pulling dbec896 on fix/psql-address into 92aa031 on master.

@SimoneLazzaris SimoneLazzaris merged commit 4129ba9 into master Jul 21, 2021
@SimoneLazzaris SimoneLazzaris deleted the fix/psql-address branch July 21, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants