Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving top down entity a base class causes problems #1399

Closed
vchelaru opened this issue May 6, 2024 · 2 comments
Closed

Giving top down entity a base class causes problems #1399

vchelaru opened this issue May 6, 2024 · 2 comments

Comments

@vchelaru
Copy link
Owner

vchelaru commented May 6, 2024

Giving the Creature (formerly Player) entity a base class called CreatureBase broke top down movement. I had to manually delete files in Creature and manually edit stuff to remove the animations specific to the child class because they were colliding. I couldn't do this in Glue UI.

Solving the problem described here should only happen after solving issue 1398:
#1398

@vchelaru
Copy link
Owner Author

vchelaru commented May 8, 2024

As I've worked on this, I ran into a few bugs and inconveniences so I'm listing them here to be fixed:

  • Marking an entity as a platformer creates a new CSV and selects the new CSV. It should not be selected because users probably don't care about this file (at least not at first), and this surprise selection interrupts the workflow.
  • Marking an entity as not a platformer or top down should remove the CSV files from the entity. The file can be left on disk for the sake of not wiping user content, but remove it from Glue so that inheritance can be properly set up.
  • Marking an entity as a platformer, then not as a platformer should remove the platformer variables.

@vchelaru
Copy link
Owner Author

Closing this out since it is now much easier to un-assign movement variables, and since it is easier to refactor an entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant