Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

[Feature Request] Allow manually setting details #2

Closed
MulverineX opened this issue Oct 8, 2020 · 5 comments
Closed

[Feature Request] Allow manually setting details #2

MulverineX opened this issue Oct 8, 2020 · 5 comments
Labels
backend Requires server side changes enhancement New feature or request frontend Requires client side changes

Comments

@MulverineX
Copy link

When adding a theme, you should be able to manually set the theme title & the path to the preview image.

@MulverineX
Copy link
Author

Also if you add this please remove my settings icons theme from the site so I can readd it

@VChet
Copy link
Owner

VChet commented Oct 9, 2020

Thanks for your feedback!
Initially, I didn't plan to add such functionality to keep the interface and interaction as simple as possible. After some thoughts, I came up with some ideas on how to implement it, but it will take more time than it seems. Also, it will be necessary to add GitHub authentication, so only the repository owner had the ability to edit the style.
I guess sooner or later I'll add this feature. For now, the algorithm collects all images from the repository, the file containing "preview" in the name or with the largest size is being selected as a preview.

@VChet VChet added backend Requires server side changes enhancement New feature or request frontend Requires client side changes labels Oct 9, 2020
@MulverineX
Copy link
Author

Thanks for the speedy reply, excited for improvements to the system. Also thank you for the info on how it looks for the preview image. The biggest part for me is the title since I don't want discord in the repo name but that's important for a generic styles site.

@VChet
Copy link
Owner

VChet commented Oct 13, 2020

Implemented.

  1. Login with your GitHub account (login button in the header).
  2. Open the style popup, enter preferable title/link to the preview, or both, and click the edit button.

@VChet
Copy link
Owner

VChet commented Oct 13, 2020

724dce3

@VChet VChet closed this as completed Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Requires server side changes enhancement New feature or request frontend Requires client side changes
Projects
None yet
Development

No branches or pull requests

2 participants