Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probable bug in SMPLH(X) class #3

Closed
SergeiGorbatiuk opened this issue Jul 30, 2019 · 1 comment
Closed

Probable bug in SMPLH(X) class #3

SergeiGorbatiuk opened this issue Jul 30, 2019 · 1 comment

Comments

@SergeiGorbatiuk
Copy link

Hello! Thanks for the great work you've done!
I have a question about the class of SMPLH (as well as SMPLX) model of package smplx from PyPi. There are following lines:

left_hand_pose = torch.einsum(
            'bi,ij->bj', [left_hand_pose, self.left_hand_components])
right_hand_pose = torch.einsum(
            'bi,ij->bj', [right_hand_pose, self.right_hand_components])

which as I understand provide axis-angle hand pose coefficients from PCA coefficients.
But when parameter use_pca set to False when initializing the model, it causes an obvious error when calling forward():

AttributeError: 'SMPLX' object has no attribute 'left_hand_components'

My question is: shouldn't there be an if-statement before this coefficient expansion?

@vchoutas
Copy link
Owner

vchoutas commented Aug 9, 2019

@SergeyGorbatyuk171 you are right! I just add the if statement.

@vchoutas vchoutas closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants