perf: upgrade setValue method in same value setting

vcjs-dev · Sep 15, 2023 · 9e25eb6 · 9e25eb6
1 parent 7450509
commit 9e25eb6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/index.d.ts b/lib/index.d.ts
@@ -44,9 +44,9 @@ interface StarscoreInstance {
 
   hoverValue: number | null
 
-  get renderValue(): number
+  readonly renderValue: number
 
-  get scoreItems(): ScoreItemsRecord[]
+  readonly scoreItems: ScoreItemsRecord[]
 
   setOptions(opts: StarscoreOptions, reRender?: boolean): StarscoreInstance
 

diff --git a/src/lib/Starscore.ts b/src/lib/Starscore.ts
@@ -58,6 +58,8 @@ class Starscore implements StarscoreInstance {
   hoverValue: number | null = null
 
   setValue(value: number) {
+    if (this.value === value) return this
+
     if (value < 0) {
       this.value = 0
     } else if (value > this.options.count) {