Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Unsafe calls to yaml.load #158

Closed
vmatare opened this issue Oct 27, 2019 · 2 comments
Closed

Unsafe calls to yaml.load #158

vmatare opened this issue Oct 27, 2019 · 2 comments

Comments

@vmatare
Copy link

vmatare commented Oct 27, 2019

metadata = yaml.load(metadata_file.read())

metadata = yaml.load(metadata_file.read())

yaml.load is deprecated, and these calls should be replaced with e.g. yaml.safe_load

See https://nvd.nist.gov/vuln/detail/CVE-2017-18342
Cf. ros/ros_comm@29053c4

@tkruse
Copy link
Contributor

tkruse commented Dec 8, 2019

I think the same was done in vcstools/wstool#134, and a small PR has high chances of being merged by me.

@dirk-thomas
Copy link
Contributor

Closing since the repository is about to be archived: see #166.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants