Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add termination interface with success completion to runner #403

Closed
kmrmt opened this issue May 25, 2020 · 2 comments
Closed
Labels

Comments

@kmrmt
Copy link
Contributor

kmrmt commented May 25, 2020

Is your feature request related to a problem? Please describe.:

Current Runner interface doesn't provide success completion.
In some cases, I want to terminate Runner with success.

Describe the solution you'd like:

Runner#Start returns (context.Context, <-chan error, error) and cancel in Start if needed.
And then, cancel parent context when catching children's context cancellation.
It can terminate process with success completion.

Describe alternatives you've considered:

Now I send SIGTERM to itself. I think it is worth than above.

@rinx
Copy link
Contributor

rinx commented May 26, 2020

For agent sidecar on init container mode, it will be also useful.

@kmrmt kmrmt changed the title [Proposal] Add interface termination with success completion to runner [Proposal] Add termination interface with success completion to runner May 28, 2020
@vankichi vankichi added this to TODO in CRE via automation Jul 13, 2020
@vankichi vankichi removed this from TODO in CRE Jul 13, 2020
@kpango
Copy link
Collaborator

kpango commented May 31, 2022

I'll work on it, and this Issue is too old.

I'll close this issue now, but I'll refer this Issue after new PR has been created.

@kpango kpango closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants