You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.:
Current Runner interface doesn't provide success completion.
In some cases, I want to terminate Runner with success.
Describe the solution you'd like:
Runner#Start returns (context.Context, <-chan error, error) and cancel in Start if needed.
And then, cancel parent context when catching children's context cancellation.
It can terminate process with success completion.
Describe alternatives you've considered:
Now I send SIGTERM to itself. I think it is worth than above.
The text was updated successfully, but these errors were encountered:
For agent sidecar on init container mode, it will be also useful.
kmrmt
changed the title
[Proposal] Add interface termination with success completion to runner
[Proposal] Add termination interface with success completion to runner
May 28, 2020
Is your feature request related to a problem? Please describe.:
Current Runner interface doesn't provide success completion.
In some cases, I want to terminate Runner with success.
Describe the solution you'd like:
Runner#Start returns (context.Context, <-chan error, error) and cancel in Start if needed.
And then, cancel parent context when catching children's context cancellation.
It can terminate process with success completion.
Describe alternatives you've considered:
Now I send SIGTERM to itself. I think it is worth than above.
The text was updated successfully, but these errors were encountered: